-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Preview] AI Integration: Adds latency based filters to add request diagnostics in Activity and some minor changes #3362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ca17a5
to
cf5eec6
Compare
b2d20ea
to
9aaa843
Compare
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryConfig.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryConfig.cs
Outdated
Show resolved
Hide resolved
cd163b5
to
f5ace49
Compare
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryOptions.cs
Outdated
Show resolved
Hide resolved
20bdd6c
to
e256162
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my understanding, under what conditions will diagnostics be set to null?
|
6ddc4bf
to
5eaa2a2
Compare
…ctor to load client properties during initialization of recorder
dfd37b5
to
f824b11
Compare
kirankumarkolli
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of this PR,
a) Using Client Builder:
b) Using Client Options:
c) Using Request Options:
In Java SDK, for Query operations it is 500ms, but in previous PRs, we decided to have threshold as 250ms in .Net SDK.
3. Changes the namespace name to
Microsoft.Azure.Cosmos.Telemetry
and fix corresponding imports.4. Changed message to "information not available" from NA if information is not available.
5. Check Scope enablement before recording any value to avoid any precalculation overhead which we might be happening before setting attribute value.
6. Remove EnableOpenTelemetry API and Add internal
EnableOpenTelemetrySupport
API to enable this feature only in preview build and for GA build internal package like tests can enable it on demand7. Add Account Host information instead of Account Name along with Cloud information in net.peer.name attribute.
8. Populate Database and Container information on Create Container calls
9. Populate Database information on Create Database Calls.
Type of change