Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PONv6] Add 3 new fields to NC. #3499

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[PONv6] Add 3 new fields to NC. #3499

wants to merge 2 commits into from

Conversation

ecigar13
Copy link
Contributor

@ecigar13 ecigar13 commented Mar 12, 2025

Reason for Change:
This change allows DNC to publish MACAddress, PrimaryIPV6 and GatewayV6 to NNC. CNS uses these fields to program routes in Swiftv2 Vnetblock scenario (single tenant)

CNS queries NIC MACAddress against the IDMS API to ensure Swift NIC is programmed.

Design doc:
https://microsoft.sharepoint.com/:w:/t/Aznet/EZy1F1lEUZpNiPwk6JsUtvcBHapTeO4yNEI6EMUxjElXnA?e=6JaEEl

Issue Fixed:

Requirements:

Notes:

@ecigar13 ecigar13 changed the title [PONv6] Add 3 new fields on NC. [WIP][PONv6] Add 3 new fields on NC. Mar 12, 2025
@ecigar13 ecigar13 marked this pull request as ready for review March 12, 2025 16:49
@Copilot Copilot bot review requested due to automatic review settings March 12, 2025 16:49
@ecigar13 ecigar13 requested a review from a team as a code owner March 12, 2025 16:49
@ecigar13 ecigar13 requested a review from agrawaliti March 12, 2025 16:49

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds three new fields to support Vnetblock routing scenarios in single tenant deployments by exposing additional network properties from CNS to NNC. Key changes include:

  • Upgrading the controller-gen version in CRD manifests.
  • Adding new CRD schema fields for defaultGatewayV6, macAddress, and primaryIPV6.
  • Updating the NetworkContainer API type with new fields reflecting these changes.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
crd/clustersubnetstate/manifests/acn.azure.com_clustersubnetstates.yaml Upgraded controller-gen version annotation.
crd/nodenetworkconfig/manifests/acn.azure.com_nodenetworkconfigs.yaml Added defaultGatewayV6, macAddress, and primaryIPV6 fields to the CRD schema.
crd/nodenetworkconfig/api/v1alpha/nodenetworkconfig.go Added corresponding fields in the NetworkContainer API type.
Comments suppressed due to low confidence (3)

crd/nodenetworkconfig/api/v1alpha/nodenetworkconfig.go:122

  • [nitpick] Consider renaming 'PrimaryIPV6' to 'PrimaryIPv6' to follow conventional IPv6 formatting.
PrimaryIPV6        string         `json:"primaryIPV6,omitempty"`

crd/nodenetworkconfig/api/v1alpha/nodenetworkconfig.go:126

  • [nitpick] Consider renaming 'DefaultGatewayV6' to 'DefaultGatewayIPv6' for consistency with IPv6 naming conventions.
DefaultGatewayV6   string         `json:"defaultGatewayV6,omitempty"`

crd/nodenetworkconfig/api/v1alpha/nodenetworkconfig.go:127

  • [nitpick] Consider renaming 'MacAddress' to 'MACAddress' to align with standard acronym usage.
MacAddress         string         `json:"macAddress,omitempty"`
@ecigar13 ecigar13 added the cns Related to CNS. label Mar 12, 2025
@ecigar13 ecigar13 changed the title [WIP][PONv6] Add 3 new fields on NC. [PONv6] Add 3 new fields on NC. Mar 12, 2025
@ecigar13 ecigar13 changed the title [PONv6] Add 3 new fields on NC. [PONv6] Add 3 new fields to NC. Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cns Related to CNS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant