-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent CNS hanging on HNS restart #3343
Merged
Merged
+24
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Signed-off-by: Evan Baker <[email protected]>
db85fb6
to
bc33abb
Compare
nddq
approved these changes
Jan 14, 2025
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
rbtr
added a commit
that referenced
this pull request
Jan 23, 2025
Signed-off-by: Evan Baker <[email protected]>
rbtr
added a commit
that referenced
this pull request
Jan 23, 2025
Signed-off-by: Evan Baker <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
* fix: prevent CNS hanging on HNS restart (#3343) Signed-off-by: Evan Baker <[email protected]> * disable gomnd Signed-off-by: GitHub <[email protected]> --------- Signed-off-by: Evan Baker <[email protected]> Signed-off-by: GitHub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change: Add timeout to HNS service restart so that CNS will fail out instead of hang during init if it gets stuck.
Issue Fixed:
Requirements:
Notes: