Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CNS] Add unit tests to Standalone SwiftV2 scenario #2932

Merged
merged 8 commits into from
Aug 27, 2024
Merged

[CNS] Add unit tests to Standalone SwiftV2 scenario #2932

merged 8 commits into from
Aug 27, 2024

Conversation

jackieluc
Copy link
Member

Reason for Change:

This adds unit tests for PR #2634 for Standalone SwiftV2.

Notes:

  • This implementation has some assumptions being made with NC programming on NMAgent that will be addressed in a future PR, once NMagent exposes an API to query for NIC programming.

@jackieluc jackieluc added cns Related to CNS. swift-v2 labels Aug 19, 2024
@jackieluc jackieluc requested a review from a team as a code owner August 19, 2024 22:54
@jackieluc jackieluc requested review from rbtr and msvik August 19, 2024 22:54
@jackieluc
Copy link
Member Author

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

peterfelts
peterfelts reviewed Aug 22, 2024
View reviewed changes
Copy link

@peterfelts peterfelts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some learning questions.

@jackieluc jackieluc enabled auto-merge August 26, 2024 20:26
paulyufan2
paulyufan2 approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@paulyufan2 paulyufan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackieluc jackieluc added this pull request to the merge queue Aug 26, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 26, 2024
@jackieluc
[CNS] Add unit tests to Standalone SwiftV2 scenario (#2932)
f1fca92 
* chore: update comments to include field keys

* test: refactor to pass in orchestrator type for CNS mock

* chore: add swiftv2 standalone context with NMAgent

* test: add swiftv2 standalone happy path tests

* test: add comments

* test: add validation tests

* feat!: remove middleware error response overriding to unexpected error

* test: fix missing argument to refactored getTestService
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2024
@paulyufan2 paulyufan2 added this pull request to the merge queue Aug 27, 2024
Merged via the queue into Azure:master with commit 0a47e17 Aug 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterfelts peterfelts peterfelts approved these changes

@msvik msvik msvik approved these changes

@paulyufan2 paulyufan2 paulyufan2 approved these changes

@rbtr rbtr Awaiting requested review from rbtr rbtr is a code owner automatically assigned from Azure/acn-cns-reviewers

Assignees
No one assigned
Labels
cns Related to CNS. swift-v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackieluc @peterfelts @msvik @paulyufan2