ci: Remove winio from replace( ) #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jpayne3506
force-pushed
the
jpayne3506/winio
branch
from
67986c5 to
d1c9f6c
Compare
huntergregory
requested changes
Jul 22, 2024
|
Even if the PR does not trigger the PR, we can still pair it by running the pipeline with the branch name. |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
paulyufan2
force-pushed
the
jpayne3506/winio
branch
from
d1c9f6c to
669261e
Compare
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run NPM Scale Test |
|
/azp run NPM Conformance Tests |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
1 similar comment
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
whoops wrong PR |
jpayne3506
force-pushed
the
jpayne3506/winio
branch
from
669261e to
bc0371c
Compare
|
/azp run NPM Conformance Tests |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
paulyufan2
approved these changes
Jul 24, 2024
huntergregory
approved these changes
Jul 24, 2024
paulyufan2
pushed a commit
that referenced
this pull request
Jul 25, 2024
* ci: remove winio from replace * chore: go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
[email protected] requires a winio version that has
winio.NewOpenFile. So we need to update the winio version. Before we update hcsshim we should check that this winio update does not cause any regressions.Issue Fixed:
Requirements:
Notes:
Loss of context for the original reasoning for replace( ) in #961 may introduce some bugs.