Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add OS scale timeout #2490

Merged
merged 1 commit into from
Jan 12, 2024
Merged

ci: add OS scale timeout #2490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions test/integration/load/load_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,13 @@ var noopDeploymentMap = map[string]string{
"linux": manifestDir + "/noop-deployment-linux.yaml",
}

// This map is used exclusively for TestLoad. Windows is expected to take 10-15 minutes per iteration.
// Will change this as scale testing results are verified. This will ensure we keep a standard performance metric.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this we will verify after merging or before ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After, as an ongoing process. Currently the only performance metric that I know of is for windows clusters and timed accordingly. Have not tested for linux or cilium specifically.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be good to keep an eye on this to verify the changes.

var scaleTimeoutMap = map[string]time.Duration{
"windows": 15 * time.Minute,
"linux": 10 * time.Minute,
}

/*
In order to run the scale tests, you need a k8s cluster and its kubeconfig.
If no kubeconfig is passed, the test will attempt to find one in the default location for kubectl config.
Expand All @@ -64,8 +71,7 @@ todo: consider adding the following scenarios
*/
func TestLoad(t *testing.T) {
clientset := kubernetes.MustGetClientset()

ctx, cancel := context.WithTimeout(context.Background(), 30*time.Minute)
ctx, cancel := context.WithTimeout(context.Background(), time.Duration(testConfig.Iterations)*scaleTimeoutMap[testConfig.OSType])
defer cancel()

// Create namespace if it doesn't exist
Expand Down