fix: add contexts to clean up fsnotify goroutines #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
added
cns
rbtr
force-pushed
the
fix/async-goroutine-leak
branch
2 times, most recently
from
611ff3a to
2d8b331
Compare
rbtr
force-pushed
the
fix/async-goroutine-leak
branch
2 times, most recently
from
9bf8433 to
8341849
Compare
rbtr
force-pushed
the
fix/async-goroutine-leak
branch
from
8341849 to
7bddc7f
Compare
camrynl
reviewed
Dec 6, 2023
rbtr
commented
Dec 6, 2023
rbtr
force-pushed
the
fix/async-goroutine-leak
branch
from
7bddc7f to
d7f90c1
Compare
ramiro-gamarra
previously approved these changes
Dec 6, 2023
camrynl
previously approved these changes
Dec 6, 2023
rbtr
commented
Dec 7, 2023
rbtr
force-pushed
the
fix/async-goroutine-leak
branch
from
d7f90c1 to
e4b246d
Compare
tyler-lloyd
reviewed
Dec 7, 2023
tyler-lloyd
reviewed
Dec 7, 2023
tyler-lloyd
reviewed
Dec 7, 2023
tyler-lloyd
approved these changes
Dec 7, 2023
ramiro-gamarra
approved these changes
Dec 7, 2023
camrynl
approved these changes
Dec 7, 2023
rbtr
force-pushed
the
fix/async-goroutine-leak
branch
from
e603778 to
cf3e738
Compare
Signed-off-by: Evan Baker <[email protected]>
Signed-off-by: GitHub <[email protected]>
rbtr
force-pushed
the
fix/async-goroutine-leak
branch
from
cf3e738 to
3b4393d
Compare
paulyufan2
pushed a commit
that referenced
this pull request
Dec 18, 2023
Signed-off-by: Evan Baker <[email protected]>
rbtr
removed
release/1.4
matmerr
pushed a commit
that referenced
this pull request
Jan 17, 2024
Signed-off-by: Evan Baker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: