fix zap logger rotation issues #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulyufan2
force-pushed
the
zaplogissuefix
branch
from
5d76c46 to
24bde54
Compare
paulyufan2
force-pushed
the
zaplogissuefix
branch
from
24bde54 to
f12fcad
Compare
paulyufan2
force-pushed
the
zaplogissuefix
branch
2 times, most recently
from
8746536 to
e535a9a
Compare
|
Can we add more to the description about what the rotation issue is ? |
vipul-21
reviewed
Nov 3, 2023
paulyufan2
force-pushed
the
zaplogissuefix
branch
from
e535a9a to
30fcb2a
Compare
| @@ -23,17 +22,6 @@ func main() { | |||
| var config common.PluginConfig | |||
| config.Version = version | |||
|
|
|||
| logDirectory := "" // Sets the current location as log directory | |||
There was a problem hiding this comment.
did we validate ipam logs moved to zap
There was a problem hiding this comment.
yes I did with this PR: #2299
Verified azure-ipam.log
tamilmani1989
approved these changes
Nov 6, 2023
paulyufan2
force-pushed
the
zaplogissuefix
branch
from
30fcb2a to
3280724
Compare
vipul-21
approved these changes
Nov 6, 2023
behzad-mir
reviewed
Nov 6, 2023
behzad-mir
approved these changes
Nov 7, 2023
paulyufan2
force-pushed
the
zaplogissuefix
branch
3 times, most recently
from
a3c2692 to
ffb25af
Compare
paulyufan2
force-pushed
the
zaplogissuefix
branch
from
ffb25af to
e1ad4aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR is to fix log rotation issue that is crashed after windows nodes are restarted.
Issue Fixed:
Requirements:
Notes: