Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Using retryOnConflict to fix v4overlay scale tests failing. #2314

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

nddq
Copy link
Contributor

@nddq nddq commented Oct 19, 2023

Reason for Change:

Issue Fixed:

Requirements:

Notes:

@nddq nddq requested a review from a team as a code owner October 19, 2023 21:46
@nddq nddq requested a review from aggarwal0009 October 19, 2023 21:46
@nddq nddq added the fix Fixes something. label Oct 19, 2023
@nddq nddq force-pushed the fix/updateReplicaRetry branch 2 times, most recently from 64df476 to 5ce6d71 Compare October 20, 2023 08:28
@nddq nddq force-pushed the fix/updateReplicaRetry branch from 5ce6d71 to 2ff81c7 Compare October 20, 2023 16:15
@nddq nddq changed the title fix: try using retryOnConflict for v4overlay scale test [DO NOT MERGE] fix: Using retryOnConflict to fix v4overlay scale tests failing. Oct 20, 2023
@nddq nddq added ci Infra or tooling. and removed do-not-merge labels Oct 20, 2023
@@ -154,5 +154,5 @@ steps:
cd test/integration/datapath
sudo -E env "PATH=$PATH" go test -count=1 datapath_windows_test.go -timeout 3m -tags connection -restartKubeproxy true -run ^TestDatapathWin$
name: "WindowsDualStackOverlayDatapathTests"
displayName: "Windows DaulStack Overlay Datapath Tests"
displayName: "Windows DualStack Overlay Datapath Tests"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after looking at a lot of pipelines running, it started to bug me 😂

@nddq nddq enabled auto-merge (squash) October 20, 2023 17:36
@nddq
Copy link
Contributor Author

nddq commented Oct 20, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@nddq nddq force-pushed the fix/updateReplicaRetry branch from 2ff81c7 to 7c75d54 Compare October 22, 2023 01:34
@jpayne3506 jpayne3506 disabled auto-merge October 26, 2023 22:55
@jpayne3506 jpayne3506 enabled auto-merge (squash) October 26, 2023 22:55
@jpayne3506 jpayne3506 force-pushed the fix/updateReplicaRetry branch from 7c75d54 to de7ddad Compare October 26, 2023 22:55
@jpayne3506 jpayne3506 merged commit 9c3cdfb into master Oct 27, 2023
@jpayne3506 jpayne3506 deleted the fix/updateReplicaRetry branch October 27, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Infra or tooling. fix Fixes something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants