fix: retry pool allocation after cleaning IPAM state #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshr-w
force-pushed
the
shjayaraman/fixaddrpoolalloc
branch
from
62c8e57 to
bfed150
Compare
| @@ -64,7 +64,10 @@ func (invoker *AzureIPAMInvoker) Add(addConfig IPAMAddConfig) (IPAMAddResult, er | |||
|
|
|||
| if err != nil && strings.Contains(err.Error(), ipam.ErrNoAvailableAddressPools.Error()) { | |||
| invoker.deleteIpamState() | |||
| logger.Info("Retry pool allocation after deleting IPAM state") | |||
There was a problem hiding this comment.
did you validate and it worked? Like CNI able to recover and second DelegateAdd call succeeded?
There was a problem hiding this comment.
Yes, I checked the logs and there was no follow-up Delete and Add call by containerd after this change was made - the container was created with the single ADD call.
tamilmani1989
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
On failure to allocate pool, this PR retries ADD immediately after IPAM state deletion in order to reduce the potential for the CNI to block.
Issue Fixed:
Requirements:
Notes: