Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix endpoints for cns pull model api calls to dnc #2284

Closed
wants to merge 2 commits into from

Conversation

smittal22
Copy link
Contributor

@smittal22 smittal22 commented Oct 10, 2023

Reason for Change:
Endpoints for API calls to DNC when CNS is running in Managed mode are incorrect. DNC expects networks string as part of the URL.

Issue Fixed:
Fixes Issue #25350573 on ADO

Requirements:

Notes:

@smittal22 smittal22 requested a review from a team as a code owner October 10, 2023 22:51
@smittal22 smittal22 changed the title [WIP] fix endpoints for cns pull model api calls to dnc Fix endpoints for cns pull model api calls to dnc Oct 10, 2023
@smittal22 smittal22 force-pushed the fix-endpoints-cns-pull branch from 4fb60b4 to 35e88a8 Compare October 10, 2023 22:58
@smittal22 smittal22 self-assigned this Oct 10, 2023
ashvindeodhar
ashvindeodhar previously approved these changes Oct 11, 2023
@ashvindeodhar
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@smittal22 smittal22 force-pushed the fix-endpoints-cns-pull branch 3 times, most recently from 08131a5 to d146e16 Compare October 17, 2023 17:38
@smittal22 smittal22 force-pushed the fix-endpoints-cns-pull branch from d146e16 to 241255a Compare October 17, 2023 17:42
@smittal22
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@smittal22
Copy link
Contributor Author

Merged this instead: #2297

@smittal22 smittal22 closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants