Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Agent pool default set at stage level #2272

Merged
merged 1 commit into from
Oct 4, 2023
Merged

ci: Agent pool default set at stage level #2272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .pipelines/singletenancy/aks-swift/e2e-job-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ stages:
CURRENT_VERSION: $[ stagedependencies.containerize.check_tag.outputs['CurrentTagManifests.currentTagManifests'] ]
commitID: $[ stagedependencies.setup.env.outputs['EnvironmentalVariables.commitID'] ]
condition: and(succeeded(), eq(variables.TAG, variables.CURRENT_VERSION))
pool:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So are these getting changed for stages even if the job has a default specified ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the job level specifies a pool then the stage level gets overwritten.

name: $(BUILD_POOL_NAME_DEFAULT)
jobs:
- job: ${{ parameters.name }}
displayName: Singletenancy AKS Swift Suite - (${{ parameters.name }})
Expand Down
2 changes: 2 additions & 0 deletions .pipelines/singletenancy/aks/e2e-job-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ stages:
- setup
- publish
- ${{ parameters.clusterName }}
pool:
name: $(BUILD_POOL_NAME_DEFAULT)
jobs:
- job: ${{ parameters.name }}
displayName: Singletenancy AKS - (${{ parameters.name }})
Expand Down
2 changes: 2 additions & 0 deletions .pipelines/singletenancy/azure-cni-overlay/azure-cni-overlay-e2e-job-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ stages:
- ${{ parameters.clusterName }}
variables:
commitID: $[ stagedependencies.setup.env.outputs['EnvironmentalVariables.commitID'] ]
pool:
name: $(BUILD_POOL_NAME_DEFAULT)
jobs:
- job: ${{ parameters.name }}
displayName: Azure CNI Overlay Test Suite - (${{ parameters.name }})
Expand Down
2 changes: 2 additions & 0 deletions .pipelines/singletenancy/cilium-overlay/cilium-overlay-e2e-job-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ stages:
- setup
- publish
- ${{ parameters.clusterName }}
pool:
name: $(BUILD_POOL_NAME_DEFAULT)
jobs:
- job: ${{ parameters.name }}
displayName: Cilium Overlay Test Suite - (${{ parameters.name }})
Expand Down
2 changes: 2 additions & 0 deletions .pipelines/singletenancy/cilium/cilium-e2e-job-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ stages:
CURRENT_VERSION: $[ stagedependencies.containerize.check_tag.outputs['CurrentTagManifests.currentTagManifests'] ]
commitID: $[ stagedependencies.setup.env.outputs['EnvironmentalVariables.commitID'] ]
condition: and(succeeded(), eq(variables.TAG, variables.CURRENT_VERSION))
pool:
name: $(BUILD_POOL_NAME_DEFAULT)
jobs:
- job: ${{ parameters.name }}
displayName: Cilium Test Suite - (${{ parameters.name }})
Expand Down
2 changes: 2 additions & 0 deletions .pipelines/singletenancy/dualstack-overlay/dualstackoverlay-e2e-job-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ stages:
GOBIN: "$(GOPATH)/bin" # Go binaries path
modulePath: "$(GOPATH)/src/github.com/Azure/azure-container-networking"
commitID: $[ stagedependencies.setup.env.outputs['EnvironmentalVariables.commitID'] ]
pool:
name: $(BUILD_POOL_NAME_DEFAULT)
jobs:
- job: ${{ parameters.name }}
displayName: DualStack Overlay Test Suite - (${{ parameters.name }})
Expand Down