[test] add hubble system test to CI #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matmerr
commented
Sep 28, 2023
| tcp:sourceContext=pod-short;destinationContext=pod-short | ||
| dns:flow:sourceContext=pod-short;destinationContext=pod-short | ||
| hubble-metrics-server: :9965 | ||
| hubble-disable-tls: "false" |
vakalapa
reviewed
Sep 29, 2023
| @@ -24,7 +24,7 @@ data: | |||
| enable-health-check-nodeport: "true" | |||
| enable-health-checking: "true" | |||
| enable-host-legacy-routing: "true" | |||
| enable-hubble: "false" | |||
| enable-hubble: "true" | |||
There was a problem hiding this comment.
lets create a separate config map ?? and keep this as is
| @@ -0,0 +1,98 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
where you are deploying this cilium config? I didn't see this config getting deployed in cilium-e2e-step-template
| @@ -0,0 +1,98 @@ | |||
| apiVersion: v1 | |||
| data: | |||
There was a problem hiding this comment.
what flags did you change from the one without hubble?
|
@matmerr instead of adding this in PR pipeline we should add it in nightly pipeline.. PR pipeline is mainly to catch regressions with cns and azure-ipam component..cilium image would be always same here |
|
cc: @jshr-w |
jshr-w
added a commit
that referenced
this pull request
Oct 20, 2023
* [test] add hubble system test to CI (#2265) * cilium configmap * update hubble configs and add metrics test * update pipeline yaml * separate cilium+hubble config * ci: move hubble connectivity test to nightly pipeline * fix: move to correct file * style: indentation change * ci: update configmap to enable Hubble * fix: move hubble test * fix: move connectivity test before delete * fix: add daemonset namespace * fix: update command for configmap replace * test no restart after replace * fix: try apply instead of replace * fix: add back restart ds * add longer timeout after ds restart * adjust timeout setup * extend timeout, add logging * add logging, change cm command * update hubble configmap * clean up sleep statements * remove hubble connectivity test from PR pipeline * use kubernetes utils * fix style Signed-off-by: jshr-w <[email protected]> * update ds restart wait * enable Hubble on nightly, disable on PR * tag networkobservability test * fix test call * enable Hubble after Cilium is ready * change location of hubble enable --------- Signed-off-by: jshr-w <[email protected]> Co-authored-by: Mathew Merrick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Validate existing Cilium scenarios with Hubble enabled
Issue Fixed:
Requirements:
Notes: