[Multitenancy]: Add PNI CRD #2134
Conversation
aggarwal0009
force-pushed
the
ankaggar/ankaggar/PNI-CRD
branch
from
1324f1c to
9f00eaf
Compare
Signed-off-by: aggarwal0009 <[email protected]>
Signed-off-by: aggarwal0009 <[email protected]>
aggarwal0009
force-pushed
the
ankaggar/ankaggar/PNI-CRD
branch
from
7a4cf67 to
4cfe869
Compare
| // PodNetworkInstanceSpec defines the desired state of PodNetworkInstance | ||
| type PodNetworkInstanceSpec struct { | ||
| // +kubebuilder:default=0 | ||
| // +kubebuilder:validation:Optional |
There was a problem hiding this comment.
not exactly sure what this annotation means but a PodNetwork is not an optional field of a PodNetworkInstance
There was a problem hiding this comment.
With omitempty in place, this annotation has no effect.. I would also need to drop omit empty from the field for it to be marked required in CRD
There was a problem hiding this comment.
so I dropped omitempty from podnetwork and it is now marked req in generated CRD.
|
|
||
| // PodNetworkInstanceStatus defines the observed state of PodNetworkInstance | ||
| type PodNetworkInstanceStatus struct { | ||
| // +kubebuilder:validation:Optional |
There was a problem hiding this comment.
same here, I wouldn't mark this optional
There was a problem hiding this comment.
removed but it has no effect. Do I need to drop omitempty from PodIPAddresses field here? They can be empty initially right?
There was a problem hiding this comment.
hm yeah let's keep it like you have it for now
Signed-off-by: aggarwal0009 <[email protected]>
aggarwal0009
dismissed stale reviews from thatmattlong and miguelgoms
via
351ea4d
|
Merging as Dual stack E2E is flaky. Pinging Ramiro to get that fixed. |
Reason for Change:
New CRD PodNetworkInstance added to enable VNET multitenancy
PNIs represent optional requirements, or behavior configurations for how we setup the pod networking. They should map 1:1 and follow the lifetime of a customer workload.
Issue Fixed:
Requirements:
Notes: