Remove Kubernetes PodInfoProvider and default to CNI initialization #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shall we wait to merge this until podsubnet CNI is installed with dropgz? my fear is that someone will forget that it's not ready to release until after that, and we'll break some clusters edit: oh nvm this is a draft, my bad |
|
@thatmattlong yep, that's why it's still a draft. that's mentioned in the description:notes |
|
+do-no-merge +work-in-progress to be more clear that this shouldn't be merged until cni installer is default everywhere |
|
depends on #2075 |
|
obsoletes/removes changes introduced in #2078 |
Signed-off-by: Evan Baker <[email protected]>
…iant Signed-off-by: Evan Baker <[email protected]>
Signed-off-by: Evan Baker <[email protected]>
Signed-off-by: Evan Baker <[email protected]>
rbtr
force-pushed
the
remove-kubereconcile
branch
from
8da36a8 to
19d1bde
Compare
|
This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days |
|
Pull request closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Removes the (long deprecated) Kubernetes reconcile branch from the CNS PodInfo initialization flow. The default is now the CNI reconcile flow, with the preference to restore from CNS own managed endpoint state if that is enabled.
Slightly repackages these components to be clearer:
both are now in pkg
podproviderinstead ofcnireconcilerCNI Pod info provider ->
podprovider/cniCNS endpoint state pod infor provider moved from cnireconciler ->
podprovider/cnsSince CNI reconciliation is becoming the default, the version check can be dropped as there is no longer another option to fall back to. We simply attempt it, and verbosely error.
Issue Fixed:
Requirements:
Notes:
Because we don't always install the CNI with CNS yet, this is not safe to release until all AKS variants are using the CNI installer init container.