Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: clean up cns state check tests #2082

Merged
merged 1 commit into from
Jul 27, 2023
Merged

test: clean up cns state check tests #2082

merged 1 commit into from
Jul 27, 2023

Conversation

thatmattlong
Copy link
Contributor

Reason for Change:
Cleans up the state validation test code to remove some anti-patterns in preparation for further extending the test code

Requirements:

Notes:

@thatmattlong thatmattlong added the ci Infra or tooling. label Jul 26, 2023
@thatmattlong thatmattlong requested a review from a team as a code owner July 26, 2023 22:49
@thatmattlong thatmattlong requested a review from timraymond July 26, 2023 22:49
@thatmattlong thatmattlong changed the title clean up cns state check tests test: clean up cns state check tests Jul 26, 2023
@rbtr rbtr requested review from vipul-21 and paulyufan2 July 27, 2023 16:18
@vipul-21
Copy link
Contributor

@thatmattlong there might be some overlap with this PR: #2047. If possible can you review that one for me ?

timraymond
timraymond previously approved these changes Jul 27, 2023
vipul-21
vipul-21 previously approved these changes Jul 27, 2023
@thatmattlong thatmattlong dismissed stale reviews from vipul-21 and timraymond via 19682cf July 27, 2023 18:20
@thatmattlong thatmattlong merged commit 24d77f1 into Azure:master Jul 27, 2023
@thatmattlong thatmattlong deleted the matlong/cleanup-cns-state-check-test branch July 27, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Infra or tooling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants