ci:[CNI] Remove load balancer tests and add rollout status for konnectivity-agent in ACN PR pipeline #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpayne3506
force-pushed
the
jpayne3506/acnpipeline
branch
2 times, most recently
from
a958fd2 to
111ee09
Compare
jpayne3506
changed the title
jpayne3506
force-pushed
the
jpayne3506/acnpipeline
branch
from
111ee09 to
2eddcd5
Compare
vipul-21
reviewed
Jul 25, 2023
| @@ -65,17 +65,6 @@ jobs: | |||
| os: ${{ parameters.os }} | |||
| processes: 8 | |||
| attempts: 3 | |||
| - ${{ if eq(parameters.loadBalancer, true) }}: | |||
There was a problem hiding this comment.
Let's make a note of everything we removing from PR pipeline should be added to cni release pipeline.
| @@ -25,6 +25,7 @@ steps: | |||
| # Taint Linux nodes so that windows tests do not run on them | |||
| if ${{ lower(eq(parameters.os, 'windows')) }} | |||
| then | |||
| kubectl rollout status -n kube-system deployment/konnectivity-agent --timeout=3m | |||
There was a problem hiding this comment.
Is this just for windows, or we need to wait for the deployment in linux as well ?
There was a problem hiding this comment.
Just for windows due to the linux node being tainted, stopping scheduling for system assets while windows tests are running.
vipul-21
approved these changes
Jul 25, 2023
rbtr
pushed a commit
that referenced
this pull request
Jan 9, 2024
…tivity-agent in ACN PR pipeline (#2072) * Remove Loadbalancer Tests * Add status check for konnectivity agent
4 tasks
rbtr
added a commit
that referenced
this pull request
Jan 9, 2024
#2487) ci:[CNI] Remove load balancer tests and add rollout status for konnectivity-agent in ACN PR pipeline (#2072) * Remove Loadbalancer Tests * Add status check for konnectivity agent Co-authored-by: John Payne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Windows e2e test require a taint on linux nodes to ensure that the tests run on the windows nodepool. This has led to konnectivity-agent pods restarting in the middle of tests without enough time to restart. Resulting in e2e tests unable to start or recover in-between steps.
Removing load balancer tests as they are not required for CNI e2e testing.
Issue Fixed:
Requirements:
Notes: