fix: return new error when no ncs found in nnc crd #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
requested changes
Jul 14, 2023
jaer-tsun
force-pushed
the
tsch/fixReconcileInitialCNSState
branch
from
a1fefb0 to
99994a8
Compare
thatmattlong
approved these changes
Jul 14, 2023
jaer-tsun
force-pushed
the
tsch/fixReconcileInitialCNSState
branch
from
5742195 to
2680951
Compare
neaggarwMS
approved these changes
Jul 17, 2023
rbtr
approved these changes
Jul 17, 2023
jaer-tsun
added a commit
to jaer-tsun/azure-container-networking
that referenced
this pull request
Jul 17, 2023
Co-authored-by: Jaeryn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
We should return a new error instead of nil error when no NCs are found in NNC CRD
Issue Fixed:
Requirements:
Notes: