Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use cached ctrlruntime client in IPAM pool monitor #2043

Merged
merged 1 commit into from
Jul 21, 2023
Merged

fix: use cached ctrlruntime client in IPAM pool monitor #2043

merged 1 commit into from
Jul 21, 2023

Conversation

rbtr
Copy link
Contributor

@rbtr rbtr commented Jul 5, 2023

Reason for Change:

Issue Fixed:

Requirements:

Notes:

@rbtr rbtr added cns Related to CNS. fix Fixes something. labels Jul 5, 2023
@rbtr rbtr self-assigned this Jul 5, 2023
@rbtr rbtr requested a review from a team as a code owner July 5, 2023 22:17
@rbtr rbtr requested a review from rsagasthya July 5, 2023 22:17
thatmattlong
thatmattlong previously approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@thatmattlong thatmattlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved but would recommend leaving a comment as noted in the review

@rbtr rbtr force-pushed the fix/cached-client branch from df5cd7c to 4981ff6 Compare July 5, 2023 22:33
@rbtr rbtr enabled auto-merge (squash) July 5, 2023 22:45
neaggarwMS
neaggarwMS requested changes Jul 6, 2023
View reviewed changes
Copy link
Member

@neaggarwMS neaggarwMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you discuss the changes with me before?

@rbtr rbtr force-pushed the fix/cached-client branch 3 times, most recently from 7fd273d to b4db01e Compare July 19, 2023 15:40
@rbtr rbtr requested review from thatmattlong and removed request for rsagasthya July 19, 2023 15:40
@rbtr rbtr force-pushed the fix/cached-client branch 2 times, most recently from 9f5bcfd to c190bb0 Compare July 19, 2023 20:46
@rbtr rbtr requested a review from neaggarwMS July 19, 2023 21:38
@rbtr rbtr force-pushed the fix/cached-client branch from c190bb0 to b6635e5 Compare July 20, 2023 16:07
@rbtr rbtr disabled auto-merge July 21, 2023 16:35
@rbtr rbtr merged commit 97fdf81 into Azure:master Jul 21, 2023
@rbtr rbtr deleted the fix/cached-client branch July 21, 2023 16:35
rbtr added a commit that referenced this pull request Sep 8, 2023
@rbtr
fix: use cached ctrlruntime client in IPAM pool monitor (#2043)
ec97b6d 
Signed-off-by: Evan Baker <[email protected]>
jpayne3506 pushed a commit that referenced this pull request Sep 11, 2023
@rbtr @jpayne3506
fix: use cached ctrlruntime client in IPAM pool monitor (#2043)
78fb4b2 
Signed-off-by: Evan Baker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatmattlong thatmattlong thatmattlong approved these changes

@neaggarwMS neaggarwMS Awaiting requested review from neaggarwMS

Assignees

@rbtr rbtr

Labels
cns Related to CNS. fix Fixes something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbtr @neaggarwMS @thatmattlong