test:[NPM] Adding service deployment for the scale test #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camrynl
previously approved these changes
Jun 8, 2023
huntergregory
requested changes
Jun 8, 2023
| local numDeployments=$2 | ||
| local serviceKind=$3 | ||
|
|
||
| for i in $(seq -f "%05g" 1 $numServices); do |
There was a problem hiding this comment.
to make --num-services optional, I think you'll need to set a default value of 0 somewhere
test/scale/test-scale.sh
Outdated
| @@ -406,6 +427,7 @@ set -x | |||
| $KUBECTL $KUBECONFIG_ARG create ns scale-test | |||
| $KUBECTL $KUBECONFIG_ARG apply -f generated/kwok-nodes/ | |||
| $KUBECTL $KUBECONFIG_ARG apply -f generated/deployments/real/ | |||
| $KUBECTL $KUBECONFIG_ARG apply -f generated/services/real/ | |||
There was a problem hiding this comment.
We'll need to apply only if numServices > 0. Like here:
https://github.com/Azure/azure-container-networking/pull/1975/files/24467195c5ac9edd90793a3befd95ebe029098f4#diff-7f8f18cf7c38d320fefc80745a20c806a8b4f626e8fb27bf7d009a0daf96de4f
There was a problem hiding this comment.
Could we also modify these NPM calculations:
- increase number of NPM IPSets by numRealDeployments when numServices > 0
- increase number of IPSet members by numRealPods
There was a problem hiding this comment.
So for:
- numIPSetsAddedByNPM : I can add the
numRealDeploymentsifnumServices > 0 - numIPSetMembersAddedByNPM: Add
numRealPodsifnumServices > 0? @huntergregory
vipul-21
force-pushed
the
singhvipul/scaletest
branch
from
f04d1a7 to
0f340e0
Compare
huntergregory
previously approved these changes
Jun 16, 2023
vipul-21
force-pushed
the
singhvipul/scaletest
branch
from
1c0437e to
1db3b50
Compare
huntergregory
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adding the option to deploy service for each set of deployments for scale test. Each service will be mapped to the respective deployment(having certain number of pods per deployment)
Issue Fixed:
Requirements:
Notes: