CNS - Remove vnet join cache check during NC publish #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lways attempted during publish. this is the classic behavior circa cns v1.4.37
rbtr
approved these changes
May 5, 2023
msvik
reviewed
May 5, 2023
| respondJSON(w, http.StatusOK, resp) // legacy behavior | ||
| logger.Response(service.Name, resp, resp.Response.ReturnCode, err) | ||
| return | ||
| joinResp, err := service.wsproxy.JoinNetwork(ctx, req.NetworkID) //nolint:govet // ok to shadow |
There was a problem hiding this comment.
Is there a way to add unit test to prevent it from happening again by accident?
rbtr
pushed a commit
that referenced
this pull request
Sep 8, 2023
removing vnet join cache check during nc publish, such that join is always attempted during publish. this is the classic behavior circa cns v1.4.37
jpayne3506
pushed a commit
that referenced
this pull request
Sep 11, 2023
removing vnet join cache check during nc publish, such that join is always attempted during publish. this is the classic behavior circa cns v1.4.37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR reverts back a change introduced in #1825, where, during an NC publish, we check if a vnet join has been performed against nmagent and skip the call if so. This change introduced a regression due to nmagent behavior: if nmagent crashes while subscribed to a vnet with no NCs published, it will not re-subscribe once restarted, making the CNS cache invalid and resulting in new NCs published erroring with unauthorized codes. Removing this cache check will make it such that the vnet is always joined before any NC is published.
We should consider reintroducing this check (which greatly minimizes wireserver calls) once we can correctly remove a vnet from the cache when it has no NC.