-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: [CNI] Add restart node in stage in the load test of cni pipeline #1916
Conversation
329c68f
to
705f829
Compare
705f829
to
7dd95d3
Compare
make -C ./hack/swift set-kubeconf AZCLI=az CLUSTER=${RESOURCE_GROUP} | ||
make -C ./hack/swift azcfg AZCLI=az REGION=$(LOCATION) | ||
echo "Scaling the pods down to 100 per node" | ||
bash ./hack/scripts/scale_deployment.sh -n 0 -u 1000 -s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it scaling down to 1000 or 100? also number of times is 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script scale up and down as a by default run. So by specifying -n
as 0 we are telling it not to do that.
The flag -s
is used to define scale up operation. We are scaling down to 1000 pods (i.e 100 pods per node) from 240 pods per node.
echo "Restarting the nodes" | ||
vmss_name=$(az vmss list -g MC_${RESOURCE_GROUP}_${RESOURCE_GROUP}_$(LOCATION) --query "[].name" -o tsv) | ||
make -C ./hack/swift restart-vmss AZCLI=az CLUSTER=${RESOURCE_GROUP} REGION=$(LOCATION) VMSS_NAME=$vmss_name | ||
bash ./hack/scripts/scale_deployment.sh -n 0 -u 1000 -c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we calling scale script again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly -c
will wait until the deployment of 1000 pods is done. The same script is used.
I added the description of what the script can do. And checking the deployment status and deploying pods(scaling pods) can be done via passing flags to the script.
If we don't wait for the deployment to finish after the restart, the validate state script will fail as few of pods( sometimes) are still being created
Reason for Change:
scale_deployment
script to include different parameters for CNI load testingRequirements:
Notes: