ci: validate pods and systemd-networkd restart for PRs #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vipul-21
reviewed
Apr 13, 2023
| @@ -17,6 +17,9 @@ do | |||
| echo "Node internal ip: $node_ip" | |||
| privileged_pod=$(kubectl get pods -n kube-system -l app=privileged-daemonset -o wide | grep "$node_name" | awk '{print $1}') | |||
| echo "privileged pod : $privileged_pod" | |||
| if [ "$privileged_pod" == '' ]; then | |||
| exit 1 | |||
There was a problem hiding this comment.
Did we encounter such case during testing ?
Can we add the status of privileged pod deployment then. ( kubectl describe daemonset privileged-daemonset -n kube-system
There was a problem hiding this comment.
sure I'll add that, here you can see this run just got stuck in the loop. I had to manually cancel it https://dev.azure.com/msazure/One/_build/results?buildId=71680459&view=logs&j=4ea62961-c456-50ab-e773-f15fbc744993&t=6637b73f-d7ef-5d5e-d4d4-eb0bbec757cb&s=c689f5d8-16f1-5a52-95fe-f6a4e6a9e7fe
There was a problem hiding this comment.
Sorry I meant if we fail to get the privileged pod then it will be good to have the status of daemon set. Basically before exiting we can have that as I see from the pipeline run, daemonset.apps/privileged-daemonset created.
Ideally we should be waiting for the deployment to be complete before proceeding i think.
There was a problem hiding this comment.
Ah makes sense, I made the switch
vipul-21
previously approved these changes
Apr 14, 2023
rbtr
reviewed
Apr 18, 2023
Comment on lines
52
to
59
| kubectl apply -f test/integration/manifests/cilium/cilium-agent/daemonset.yaml | ||
| kubectl apply -f test/integration/manifests/cilium/cilium-agent/clusterrole.yaml | ||
| kubectl apply -f test/integration/manifests/cilium/cilium-agent/clusterrolebinding.yaml | ||
| kubectl apply -f test/integration/manifests/cilium/cilium-agent/serviceaccount.yaml | ||
| kubectl apply -f test/integration/manifests/cilium/cilium-operator/deployment.yaml | ||
| kubectl apply -f test/integration/manifests/cilium/cilium-operator/serviceaccount.yaml | ||
| kubectl apply -f test/integration/manifests/cilium/cilium-operator/clusterrole.yaml | ||
| kubectl apply -f test/integration/manifests/cilium/cilium-operator/clusterrolebinding.yaml |
There was a problem hiding this comment.
kubectl apply works on directories. if these have ordering constraints, name the files with a priority prefix.
Suggested change
| kubectl apply -f test/integration/manifests/cilium/cilium-agent/daemonset.yaml | |
| kubectl apply -f test/integration/manifests/cilium/cilium-agent/clusterrole.yaml | |
| kubectl apply -f test/integration/manifests/cilium/cilium-agent/clusterrolebinding.yaml | |
| kubectl apply -f test/integration/manifests/cilium/cilium-agent/serviceaccount.yaml | |
| kubectl apply -f test/integration/manifests/cilium/cilium-operator/deployment.yaml | |
| kubectl apply -f test/integration/manifests/cilium/cilium-operator/serviceaccount.yaml | |
| kubectl apply -f test/integration/manifests/cilium/cilium-operator/clusterrole.yaml | |
| kubectl apply -f test/integration/manifests/cilium/cilium-operator/clusterrolebinding.yaml | |
| kubectl apply -f test/integration/manifests/cilium/cilium-agent | |
| kubectl apply -f test/integration/manifests/cilium/cilium-operator |
Comment on lines
85
to
93
| creationTimestamp: "2023-04-17T23:00:12Z" | ||
| labels: | ||
| app.kubernetes.io/managed-by: Helm | ||
| helm.toolkit.fluxcd.io/name: cilium-adapter-helmrelease | ||
| helm.toolkit.fluxcd.io/namespace: 643dcea81aff3b00014098f5 | ||
| name: cilium-config | ||
| namespace: kube-system | ||
| resourceVersion: "993" | ||
| uid: 31ccec09-0511-4f18-b21a-10cf4033ce06 |
rbtr
approved these changes
Apr 19, 2023
rbtr
pushed a commit
that referenced
this pull request
Sep 8, 2023
* update script to check cns in memory and add to pr pipeline * adding stage to both overlay and podsubnet cilium stages * add exit case if priveleged pod is not found * check status of priv pod * call ds status before exit * install cilium ds with kubectl and not helm for systemd-networkd initcontainer patch * upload cilium ds * adding files for cilium-agent and cilium-operator deployment * update cilium ds * addressing comments
jpayne3506
pushed a commit
that referenced
this pull request
Sep 11, 2023
* update script to check cns in memory and add to pr pipeline * adding stage to both overlay and podsubnet cilium stages * add exit case if priveleged pod is not found * check status of priv pod * call ds status before exit * install cilium ds with kubectl and not helm for systemd-networkd initcontainer patch * upload cilium ds * adding files for cilium-agent and cilium-operator deployment * update cilium ds * addressing comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes:
verified script manually and on both ACN PR and load test pipeline.
Load Test Pipeline run: https://msazure.visualstudio.com/One/_build/results?buildId=71640453&view=logs&j=aafe78ca-85dd-54d8-c96a-840101a5fad4