add logs for home az monitor #1899
Conversation
ZetaoZhuang
requested review from
thatmattlong and
ashvindeodhar
and removed request for
a team
cns/restserver/homeazmonitor.go
Outdated
| h.updateCacheValue(resp) | ||
| } | ||
|
|
||
| // logHomeAzResponse logs HomeAz Response | ||
| func (h *HomeAzMonitor) logHomeAzResponse(resp cns.GetHomeAzResponse) { |
There was a problem hiding this comment.
Hey Zetao, thinking more on this, I think we should log the HomeAzResponse everytime ( not just when it gets updated ). That's because, we may lose the AZ log if it doesn't change ( which it shouldn't ) for long time. Having that log would be beneficial.
There was a problem hiding this comment.
that is right. I will update this
There was a problem hiding this comment.
we don't need the func body below. We should just print the resp struct here.
There was a problem hiding this comment.
but in this way we can log it as error when there have errors in refreshing home az. it makes more flexible to set alerts in future.
There was a problem hiding this comment.
I would keep the logging simple. Since we already have logic in DNC to identify mismatch on the home AZ we can add alerting there
Reason for Change:
Issue Fixed:
Requirements:
Notes: