timeout after 15 minutes waiting for the NNC reconciler to start #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
requested review from
ramiro-gamarra and
neaggarwMS
and removed request for
a team
Signed-off-by: Evan Baker <[email protected]>
Signed-off-by: Evan Baker <[email protected]>
Signed-off-by: Evan Baker <[email protected]>
csfmomo
reviewed
Mar 31, 2023
csfmomo
reviewed
Mar 31, 2023
csfmomo
approved these changes
Mar 31, 2023
rbtr
added a commit
that referenced
this pull request
Sep 8, 2023
* timeout after 15 minutes waiting for the NNC reconciler to start Signed-off-by: Evan Baker <[email protected]> * log error and retry instead of crashing out Signed-off-by: Evan Baker <[email protected]> * add metric for nnc reconciler failed to start Signed-off-by: Evan Baker <[email protected]> --------- Signed-off-by: Evan Baker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Currently we wait indefinitely for the NNC reconciler to receive an NNC and run the first reconcile before continuing execution (starting the CNS webserver, IPAM pool monitor, etc).
Instead, if the NNC Reconciler does not get an NNC and successfully run a reconcile within 15 minutes, timeout and fail to make it evident that CNS is encountering a fatal error/stuck.
Issue Fixed:
Requirements:
Notes: