Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: [WIN-NPM] remove ws19 build #1844

Merged
merged 6 commits into from
Apr 11, 2023
Merged

Conversation

huntergregory
Copy link
Contributor

Unnecessary build. NPM isn't supported on Windows Server 2019

@huntergregory huntergregory added npm Related to NPM. windows labels Mar 8, 2023
@huntergregory huntergregory requested a review from rbtr March 8, 2023 22:08
@huntergregory
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@rbtr
Copy link
Contributor

rbtr commented Mar 9, 2023

looks like these OS_VERSIONs set in the pipeline step are not being propogated - the Makefile should probably say OS_VERSIONS=$(OS_VERSIONS) instead of having them hardcoded here

Copy link
Contributor

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs Makefile fix for OS_VERSIONS (can you update the CNS manifest target also?)

@huntergregory
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@vakalapa vakalapa merged commit d7fc7e2 into master Apr 11, 2023
@vakalapa vakalapa deleted the hgregory/remove-npm-ws19-build branch April 11, 2023 21:35
jpayne3506 pushed a commit that referenced this pull request Jun 26, 2024
* remove NPM build for ws19

* set OS versions by variable in manifest-build

---------

Co-authored-by: Vamsi Kalapala <[email protected]>
jpayne3506 added a commit that referenced this pull request Jun 26, 2024
* ci: Change ACR Service Connection (#2727)

* fix: pin Windows images (#2742)

Signed-off-by: Evan Baker <[email protected]>

* ci: [WIN-NPM] remove ws19 build (#1844)

* remove NPM build for ws19

* set OS versions by variable in manifest-build

---------

Co-authored-by: Vamsi Kalapala <[email protected]>

---------

Signed-off-by: Evan Baker <[email protected]>
Co-authored-by: Evan Baker <[email protected]>
Co-authored-by: Hunter Gregory <[email protected]>
Co-authored-by: Vamsi Kalapala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Related to NPM. windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants