add cilium overlay to hackfile #1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakalapa
previously approved these changes
Mar 7, 2023
Signed-off-by: Evan Baker <[email protected]>
nairashu
reviewed
Mar 8, 2023
| $(AZCLI) aks create -n $(CLUSTER) -g $(GROUP) -l $(REGION) \ | ||
| --node-count 2 \ | ||
| --node-vm-size $(VM_SIZE) \ | ||
| --load-balancer-sku basic \ |
There was a problem hiding this comment.
Info Question: Are we tied to using only basic SKUs for Cilium? SLB recommendations was to move to Stnadard SKUs across the board so that they could deprecate Basic SKUs
There was a problem hiding this comment.
No, these are not limitations. I have just tended towards the cheapest config possible since this is targeted for quick cluster creation, dev work, and CI use
nairashu
approved these changes
Mar 8, 2023
rjdenney
pushed a commit
that referenced
this pull request
Mar 13, 2023
Signed-off-by: Evan Baker <[email protected]>
rbtr
added a commit
that referenced
this pull request
Sep 8, 2023
Signed-off-by: Evan Baker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: