Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Network} az network nic create: Refine help message #13513

Merged
merged 3 commits into from
May 15, 2020

Conversation

mmyyrroonn
Copy link
Contributor

@mmyyrroonn mmyyrroonn commented May 15, 2020

Description

Fix #13258

Before
image

After
image

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

MyronFanQiu added 2 commits May 15, 2020 11:18
@mmyyrroonn mmyyrroonn changed the title {Network} {Network} az network nic create: Refine help message May 15, 2020
@@ -43,9 +43,10 @@ def get_folded_parameter_help_string(
# add parent name option string (if applicable)
if other_required_option:
help_text = '{} If name specified, also specify {}.'.format(help_text, other_required_option)
help_text = '{} If you want to use an existing {display_name} in other resource group or subscription, ' \
help_text = '{} If you want to use an existing {display_name} in other resource group{append_sub}, ' \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly provide a sample output in the PR description.

@yonzhan yonzhan added this to the S170 milestone May 15, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented May 15, 2020

add to S170

@mmyyrroonn mmyyrroonn merged commit bae215b into Azure:dev May 15, 2020
@mmyyrroonn mmyyrroonn deleted the fix-13258-refine-subnet-help branch May 15, 2020 07:13
derekbekoe added a commit to derekbekoe/azure-cli that referenced this pull request May 18, 2020
* 'dev' of https://github.com/Azure/azure-cli: (85 commits)
  {Monitor} az monitor autoscale profile show: bug fix (Azure#13515)
  [Monitor] az monitor diagnostic-settings create: support --export-to-specific-resource argument (Azure#13544)
  [aro]Add tests for generate_random_id function (Azure#13522)
  [ARO]Change CLIError to correct flag for --worker-vm-disk-size-gb (Azure#13439)
  [Packaging] Add Ubuntu Focal Package (Azure#13491)
  Update parse_zone_file.py (Azure#13377)
  {Release} Upgrade to Azure CLI 2.6.0 (Azure#13542)
  fix (Azure#13511)
  {Resource} Add example to tell how to pass array to --parameters (Azure#13510)
  [NetAppFiles] Anf 5207 Bugfix - add missing snapshot restore function (Azure#13481)
  {Network} az network nic create: Refine help message (Azure#13513)
  [Storage] az storage blob sync: Fix the incorrect error message when azcopy cannot find the installation location (Azure#9576)  (Azure#13104)
  Support --connect-string for az storage blob sync (Azure#13135)
  Modify the deprecate information for deployment operation (Azure#13390)
  [AppService] Onboard local context for app service (Azure#12984)
  {Monitor} az monitor metrics alert: refine severity explanation (Azure#13512)
  [IoT Hub] Support for 2020-03-01 API and Network Isolation commands (Azure#13467)
  [Compute] az vm list-skus: Update --zone behavior, return all type skus now (Azure#13470)
  Fix that cli doe not fail when user only specifies Windows password (Azure#13418)
  {ACR}: expose --expiration from token commands (Azure#13451)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating NIC in the VNET from different subscription
4 participants