Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitor]support vm monitor metric tail/list-definitions #11528

Merged
merged 22 commits into from
Dec 25, 2019

Conversation

mmyyrroonn
Copy link
Contributor

@mmyyrroonn mmyyrroonn commented Dec 10, 2019

Fix #11276


  • support az vm monitor metrics tail to query the latest metric for a vm.
  • support az vm monitor metrics list-definitions to list the metric definitions for a vm.

This checklist is used to make sure that common guidelines for a pull request are followed.

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

  • I adhere to the Command Guidelines.

@mmyyrroonn mmyyrroonn requested a review from qwordy December 10, 2019 06:31
parameters:
- name: --aggregation
short-summary: The list of aggregation types (space-separated) to retrieve.
populator-commands:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know where these keys (e.g. populator-commands) come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, actually, I don't know. I copy these help from monitor part since it's two separate commands.

@mmyyrroonn mmyyrroonn force-pushed the fix-11276-vm-metric-tail branch from 3be5294 to 428e705 Compare December 11, 2019 03:08
@mmyyrroonn mmyyrroonn requested a review from jiasli as a code owner December 11, 2019 03:08
@mmyyrroonn mmyyrroonn requested a review from qwordy December 11, 2019 03:09
Copy link
Member

@qwordy qwordy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me😄

@mmyyrroonn mmyyrroonn force-pushed the fix-11276-vm-metric-tail branch from bc5c2f6 to 68149e4 Compare December 25, 2019 02:00
@mmyyrroonn mmyyrroonn requested a review from jiasli December 25, 2019 02:00
@mmyyrroonn mmyyrroonn merged commit 93a50bb into Azure:dev Dec 25, 2019
@mmyyrroonn mmyyrroonn deleted the fix-11276-vm-metric-tail branch December 25, 2019 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Monitor]az vm monitor metrics tail -n MyVm --metric SuccessE2ELatency
4 participants