Change the default credits for the RPC link to be more reasonable (1000) #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulting to 1 today) In the future we could control this manually since we know when responses are expected. This should be fine in the meantime.
|
Going to hold onto this for a moment. There appears to be an interesting bottleneck in one of my tests. |
serbrech
reviewed
Aug 28, 2021
|
this is really needed with the unique link for the RPCClient. |
jhendrixMSFT
reviewed
Sep 3, 2021
jhendrixMSFT
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a higher link credit count by default for the rpc link (it's defaulting to 1 today)
In the future we could control this manually since we know when responses are expected. This should be fine in the meantime.