Revert client signature endpoint to base_url to avoid breaking for Mgmt SDK
#2758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msyyc
commented
Aug 9, 2024
| @@ -231,7 +231,7 @@ async function _regenerateSingle(spec: string, flags: RegenerateFlags): Promise< | |||
| // Perform some asynchronous operation here | |||
| const options = addOptions(spec, PLUGIN_DIR, flags); | |||
| const commandPromises = options.map((option) => { | |||
| const command = `tsp compile ${spec} --emit=${PLUGIN_DIR} ${option}`; | |||
| const command = `tsp compile ${spec} --emit=${toPosix(PLUGIN_DIR)} ${option}`; | |||
There was a problem hiding this comment.
emitter-options shall be posix path style otherwise cause warning: microsoft/typespec#4023
msyyc
commented
Aug 9, 2024
| @@ -46,13 +46,12 @@ def __init__( | |||
| self, | |||
| credential: "TokenCredential", | |||
| subscription_id: str, | |||
| *, | |||
| endpoint: str = "https://management.azure.com", | |||
| base_url: str = "https://management.azure.com", | |||
There was a problem hiding this comment.
Revert client signature endpoint to base_url to avoid breaking for Mgmt SDK (example of real case: https://github.com/Azure/azure-sdk-for-python/blob/131e9ab94a8dec847426337001605001d7e1f0cb/sdk/apicenter/azure-mgmt-apicenter/azure/mgmt/apicenter/_api_center_mgmt_client.py#L69-L74)
msyyc
commented
Aug 9, 2024
| await client.top_level_tracked_resources.get(RESOURCE_GROUP_NAME, "top") | ||
| # make sure signautre name is correct | ||
| await client.top_level_tracked_resources.get( | ||
| resource_group_name=RESOURCE_GROUP_NAME, top_level_tracked_resource_name="top" |
There was a problem hiding this comment.
Add test case to avoid client signature breaking in the future.
iscai-msft
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert client signature
endpointtobase_urlto avoid breaking for Mgmt SDK