Snake case naming optimization #2637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msyyc
commented
Jun 14, 2024
| @@ -21,6 +22,9 @@ export function camelToSnakeCase(name: string): string { | |||
| .replace(/[A-Z]/g, (letter) => `_${letter.toLowerCase()}`) | |||
| .replace(/_+/g, "_"); | |||
|
|
|||
| if (!name.toLocaleLowerCase().includes("constructor")) { | |||
| return Style.snake(name, false); | |||
There was a problem hiding this comment.
With reference of m4 which also use Style of package "@azure-tools/codegen".
I also find a very interesting point in TypeScript:
"constrcutor" is very special word so it is not safe for if (data["constructor"]) to judge the key exists
tadelesh
reviewed
Jun 14, 2024
iscai-msft
reviewed
Jun 25, 2024
...espec-python/test/azure/generated/azure-mgmt-spheredpg/azure/mgmt/spheredpg/models/_enums.py
Show resolved
Hide resolved
|
@msyyc I think this PR is ready to go, I'd wait until you finish the regenerate existing packages pipeline, so we can see everything that changes |
…snake-case-naming-optimization
Here is the diff caused by this PR: Azure/azure-sdk-for-python@378a646 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2636
move to #2810