Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pool used by eng/pipelines/fluent_integration.yaml to azsdk-pool-mms-win-2022-general / MMS2022Compliant #1980

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Update pool used by eng/pipelines/fluent_integration.yaml to azsdk-pool-mms-win-2022-general / MMS2022Compliant #1980

merged 1 commit into from
Feb 15, 2023

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Feb 15, 2023 •
edited
Loading

@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Feb 15, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Feb 15, 2023
weidongxu-microsoft
weidongxu-microsoft approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDK repo seems be using "vmImage: MMS2022"
https://github.com/Azure/azure-sdk-for-java/blob/main/eng/pipelines/templates/stages/platform-matrix.json#L8

Is there a difference?

@konrad-jamrozik
Copy link
Contributor Author

SDK repo seems be using "vmImage: MMS2022" https://github.com/Azure/azure-sdk-for-java/blob/main/eng/pipelines/templates/stages/platform-matrix.json#L8

Is there a difference?

It should be also using MMS2022Compliant, thanks for pointing it out. I will make a PR updating it.

@weidongxu-microsoft weidongxu-microsoft merged commit 287f587 into main Feb 15, 2023
@weidongxu-microsoft weidongxu-microsoft deleted the users/kojamroz/update_pools_to_compliant branch February 15, 2023 05:56
@konrad-jamrozik
Copy link
Contributor Author

SDK repo seems be using "vmImage: MMS2022" https://github.com/Azure/azure-sdk-for-java/blob/main/eng/pipelines/templates/stages/platform-matrix.json#L8
Is there a difference?

It should be also using MMS2022Compliant, thanks for pointing it out. I will make a PR updating it.

@konrad-jamrozik konrad-jamrozik mentioned this pull request Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@benbp benbp Awaiting requested review from benbp

@weshaggard weshaggard Awaiting requested review from weshaggard

@mikeharder mikeharder Awaiting requested review from mikeharder

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Azure SDK EngSys 🤖🧠
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konrad-jamrozik @weidongxu-microsoft