fix(dpg): same type property only mock once #3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix DFS logic to remove visited type from hashset after being traversed - add test case fix Azure#3632
archerzz
requested review from
m-nash,
jsquire,
lirenhe,
ArthurMa1978,
hallipr and
mikeharder
as code owners
ArcturusZhang
approved these changes
Aug 3, 2023
|
Preview PR: Azure/azure-sdk-for-net#38000 As you can see, some missing mock values are added. |
lirenhe
approved these changes
Aug 3, 2023
iscai-msft
added a commit
that referenced
this pull request
Aug 3, 2023
…into getAllModels * 'feature/v3' of https://github.com/Azure/autorest.csharp: fix(dpg): same type property only mock once (#3633)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #3632
Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?