This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Wrap stats update with lock during parallel sync #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkmsft
reviewed
Jul 26, 2019
| @@ -58,7 +58,9 @@ type Client struct { | |||
| SyncLoopStarted bool | |||
| syncRetryInterval time.Duration | |||
|
|
|||
| syncing int32 // protect against conucrrent sync's | |||
| syncing int32 // protect against conucrrent sync's | |||
| statsMutex sync.Mutex | |||
There was a problem hiding this comment.
I think this should be a stats property and locking should be internally handled by stats.
There was a problem hiding this comment.
This is really the only place where stats is updated in parallel currently. I think we can switch to moving it to stats and wrapping in structs next.
|
Merging with the TODO that we will move the mutex to inside stats before 1.5 release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Wrap stats update with a lock to prevent concurrent access in the sync loop where nodes are processed in parallel.
Issue Fixed:
Notes for Reviewers: