Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/certificates #423

Merged
merged 13 commits into from
May 8, 2020
Merged

Hotfix/certificates #423

merged 13 commits into from
May 8, 2020

Conversation

cristipogacean
Copy link
Contributor

No description provided.

@cristipogacean cristipogacean requested a review from a team as a code owner May 6, 2020 10:29
@cristipogacean cristipogacean self-assigned this May 6, 2020
hansgschossmann
hansgschossmann previously approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@hansgschossmann hansgschossmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cristipogacean
build tests fix attempt
a0ad65e 
* consistently use the Dns.GetHostName()
marcschier
marcschier previously approved these changes May 6, 2020
View reviewed changes
@mregen
Copy link
Contributor

mregen commented May 7, 2020 •
edited
Loading 

            "OPC Foundation/CertificateStores/UA Certificate Authorities",

this is very old style and should be pki/issuers #Closed

Refers to: components/opc-ua/src/Microsoft.Azure.IIoT.OpcUa.Gateway/src/Server/GatewayServer.cs:1625 in eaae888. [](commit_id = eaae888, deletion_comment = False)

@mregen
Copy link
Contributor

mregen commented May 7, 2020 •
edited
Loading 

            "OPC Foundation/CertificateStores/UA Applications",

pki/trusted #Closed

Refers to: components/opc-ua/src/Microsoft.Azure.IIoT.OpcUa.Gateway/src/Server/GatewayServer.cs:1620 in eaae888. [](commit_id = eaae888, deletion_comment = False)

@mregen
Copy link
Contributor

mregen commented May 7, 2020 •
edited
Loading 

            "OPC Foundation/CertificateStores/RejectedCertificates",

pki/rejecetd #Closed

Refers to: components/opc-ua/src/Microsoft.Azure.IIoT.OpcUa.Gateway/src/Server/GatewayServer.cs:1630 in eaae888. [](commit_id = eaae888, deletion_comment = False)

mregen
mregen previously approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pc-avatar-7076 pc-avatar-7076 mentioned this pull request May 7, 2020
Closed
@cristipogacean cristipogacean requested a review from marcschier May 7, 2020 19:06
@cristipogacean cristipogacean requested a review from marcschier May 8, 2020 10:36
@cristipogacean cristipogacean merged commit d13faea into master May 8, 2020
@cristipogacean cristipogacean deleted the hotfix/certificates branch May 8, 2020 11:49
@cristipogacean cristipogacean mentioned this pull request May 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcschier marcschier marcschier approved these changes

@mregen mregen mregen left review comments

@hansgschossmann hansgschossmann hansgschossmann left review comments

Assignees

@cristipogacean cristipogacean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cristipogacean @mregen @hansgschossmann @marcschier