Update msi secret name in key vault #4086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennerv
requested review from
jewzaam,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
mociarain,
kimorris27,
tsatam,
bitoku,
fahlmant and
sankur-codes
as code owners
bennerv
force-pushed
the
bvesel/update-msi-naming-once-again
branch
from
300608c to
b49ca16
Compare
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kimorris27
approved these changes
Feb 5, 2025
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
We want a consistent naming convention for the MSI secret name so the certificate refresher can know what secrets to refresh. As a result, all uamsis are prefixed with the constant in msi-dataplane library.
Test plan for issue:
Unit tests.