Remove dnf cronjob #3840
Merged
Remove dnf cronjob #3840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatic OS Updates are configured. Updating packages via a cron job is no longer required.
Certificate generation has been broken up into a named function for each VMSS role. This means it's no longer necessary to provide the certs=true argumenet when checking VMSS roles. Add a comment for why AZURE_CLOUD_NAME returns an error if unset. Remove az cli login comment from pull_container_images, it is no longer relevant after the last refactor.
s-fairchild
added
enhancement
s-fairchild
changed the title
s-fairchild
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam and
bitoku
as code owners
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kimorris27
reviewed
Sep 16, 2024
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SudoBrendan
approved these changes
Sep 17, 2024
cadenmarchese
approved these changes
Sep 17, 2024
kimorris27
approved these changes
Sep 17, 2024
edisonLcardenas
pushed a commit
that referenced
this pull request
Sep 18, 2024
* Remove dnf update cron job Automatic OS Updates are configured. Updating packages via a cron job is no longer required. * Remove certs arg from verify_role, Add/Remove comments Certificate generation has been broken up into a named function for each VMSS role. This means it's no longer necessary to provide the certs=true argumenet when checking VMSS roles. Add a comment for why AZURE_CLOUD_NAME returns an error if unset. Remove az cli login comment from pull_container_images, it is no longer relevant after the last refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-10293
What this PR does / why we need it:
This pull request addresses unresolved feedback in PR #3741.
It also removes the
dnf updatecron job. This is no longer necessary, given that Automatic OS updates are enabled now.Test plan for issue:
Deploy to full service dev rp environment.
Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
I have successfully deployed this in my full service dev environment.