Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed to correctly reference the local image tag #3796

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

shubhadapaithankar
Copy link
Collaborator

Which issue this PR addresses:

Fixed Makefile to use local image for runlocal-rp target

Updated the runlocal-rp target to correctly reference the locally built aro image instead of attempting to pull from Docker Hub. This resolves the issue to incorrectly attempting to pull the aro image

What this PR does / why we need it:

This PR updates the runlocal-rp target to correctly use the local aro image.
This change ensures that the locally built image is referenced, improving the reliability of the local development setup.

Test plan for issue:

  • Verified functionality by running the runlocal-rp target and confirming it uses the local image.
  • No additional unit or integration tests were added as the change is related to the build process.

Is there any documentation that needs to be updated for this PR?

N/A

How do you know this will function as expected in production?

N/A

@shubhadapaithankar
Copy link
Collaborator Author

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@shubhadapaithankar shubhadapaithankar changed the title Fixed to correctly reference the local image, preventing unauthoriz… Fixed to correctly reference the local image tag Aug 27, 2024
@mociarain mociarain merged commit fd2b2f9 into master Aug 28, 2024
19 checks passed
@mociarain mociarain deleted the shubhadapaithankar/runlocal-rp-version-fix branch August 28, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants