ARO-9263: Add ACR token issue date and check validity #3778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SudoBrendan
previously requested changes
Sep 5, 2024
|
/azp run ci, e2e |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
edisonLcardenas
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27 and
tsatam
as code owners
hawkowl
force-pushed
the
hawkowl/mimo-m1
branch
from
745f0ef to
83b3a33
Compare
|
Please rebase pull request. |
hawkowl
force-pushed
the
hawkowl/mimo-m1
branch
from
4269f7e to
a989623
Compare
hawkowl
force-pushed
the
hawkowl/mimo-m1
branch
from
83e35c5 to
29f8d05
Compare
|
Please rebase pull request. |
edisonLcardenas
force-pushed
the
ecardena/ARO-9263-mimo-m1-add-acr-token-expiration-checker
branch
from
e22da94 to
c80d941
Compare
jaitaiwan
approved these changes
Sep 23, 2024
Comment on lines
46
to
48
| if issueDate == nil { | ||
| return mimo.TerminalError(errors.New("no issue date detected")) | ||
| } |
There was a problem hiding this comment.
If we don't have an issue date we've probably got a token that will never expire. Shouldn't we remove it anyway?
| return mimo.TerminalError(errors.New("no issue date detected")) | ||
| } | ||
|
|
||
| daysInterval := int32(now.Sub(issueDate.Time).Hours() / 24) |
There was a problem hiding this comment.
I feel like we should just be making use of golang's inbuilt duration funcs for this. Something like this:
now := time.Now().UTC()
lastValidIssue := now.Sub(daysShouldRotate * time.Day)
lastValidRotation := now.Sub(daysValid * time.Day)
if issueDate.Time.Before(lastValidIssue) {
return mimo.TerminalError(fmt.Errorf("%d days have passed since azure container registry (acr) token was issued, please rotate the token now", daysInterval))
}
if issueDate.Time.Before(lastValidRotation) {
return mimo.TerminalError(fmt.Errorf("azure container registry (acr) token is not valid, %d days have passed", daysInterval))
}
29f8d05 to
f760cda
Compare
|
Please rebase pull request. |
…es detected by automated checks
edisonLcardenas
force-pushed
the
ecardena/ARO-9263-mimo-m1-add-acr-token-expiration-checker
branch
from
1546e57 to
9a51858
Compare
hawkowl
deleted the
ecardena/ARO-9263-mimo-m1-add-acr-token-expiration-checker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Jira https://issues.redhat.com/browse/ARO-8472
https://issues.redhat.com/browse/ARO-9263
What this PR does / why we need it:
Test plan for issue:
Unit tests.
Manual validation.
Is there any documentation that needs to be updated for this PR?
Part of MIMO M1
How do you know this will function as expected in production?
Unit tests.