Add scripts to create platform identities for dev #3734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niontive
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
AldoFusterTurpin,
kimorris27 and
tsatam
as code owners
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kimorris27
previously approved these changes
Jul 30, 2024
|
I wrote a ticket for the E2E flake that occurred: https://issues.redhat.com/browse/ARO-9445 |
|
Please rebase pull request. |
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kimorris27
previously approved these changes
Aug 7, 2024
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kimorris27
requested changes
Aug 19, 2024
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kimorris27
approved these changes
Aug 19, 2024
SudoBrendan
approved these changes
Aug 19, 2024
| echo "Cluster MSI Client ID: $mockClientID" | ||
| echo "Cluster MSI Tenant ID: $mockTenantID" | ||
| echo "Cluster MSI Base64 Encoded Certificate: $base64EncodedCert" |
There was a problem hiding this comment.
nit: This isn't a change you introduced, but if we're here anyways... If I'm reading all this correctly - this is a private key? It's best to not print secrets to STDOUT even if it's obfuscated by base64 (encoding != encrypting; this string is effectively plaintext).
rhamitarora
approved these changes
Aug 21, 2024
cadenmarchese
approved these changes
Aug 21, 2024
edisonLcardenas
pushed a commit
that referenced
this pull request
Sep 16, 2024
--------- Co-authored-by: Nicolas Ontiveros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-8997
What this PR does / why we need it:
Platform identities will be used for MIWI local dev cluster.
Test plan for issue:
I ran the scripts
Is there any documentation that needs to be updated for this PR?
Yes - see PR
How do you know this will function as expected in production?