Bug fix - clear ReadOnly fields on PUT or PATCH for 2023-11-22 and 2024-08-12-preview APIs #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run e2e, ci |
|
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
I pulled these changes into #3529 and ran an az aro update + az aro update --refresh-credentials, and it works! Let me know if you need any additional manual smoke tests for sanity's sake.
12 tasks
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tony-schndr
force-pushed
the
tony-schndr/ARO-7192-fix-readonly-fields
branch
from
f03fd26 to
1d6eac9
Compare
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tony-schndr
force-pushed
the
tony-schndr/ARO-7192-fix-readonly-fields
branch
from
1d6eac9 to
d973e6b
Compare
tony-schndr
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan and
anshulvermapatel
as code owners
|
/azp run e2e, ci |
|
Azure Pipelines successfully started running 2 pipeline(s). |
cadenmarchese
approved these changes
Apr 26, 2024
cadenmarchese
added a commit
that referenced
this pull request
Apr 29, 2024
|
I've tested this change in lower environments as part of #3529 so I'm going to go ahead and get it merged. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-7192
What this PR does / why we need it:
Clears the ReadOnly fields on PUT or PATCH requests in 2023-11-22 and 2024-08-12-preview APIs. The addition of clearing the fields on PUT requests is due to the frontend prepopulating fields it "thinks" are expected, toInternal() preserves these fields.
Test plan for issue:
Ran e2e against api 2023-11-22
Existing unit tests
created cluster and ran az aro update against 2023-11-22
Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?