-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't add security context on <4.11 as OpenShift restricted SCCs do not tolerate it #3401
Don't add security context on <4.11 as OpenShift restricted SCCs do not tolerate it #3401
Conversation
d5b2d54
to
1458954
Compare
/hold on testing - cc @SrinivasAtmakuri |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One concern about a possible panic and a couple of optional minor suggestions.
Thank you!
6fc7815
to
141babd
Compare
141babd
to
0e6c742
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the minor tweaks.
What this PR does / why we need it:
In <4.11, the SCCs don't align with the secCompProfile set on the pods, which result in the pods with the added
secCompProfile
failing to schedule / run.Test plan for issue:
Unit tests + manual testing of 4.10 version
Testing instructions:
Changes
.spec.template.spec
.spec.template.spec.containers[]
Is there any documentation that needs to be updated for this PR?
nope