adding API Version for snapshots #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makdaam
requested review from
jim-minter,
mjudeikis and
olga-mir
as code owners
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Relates to #1313 (quickfix, needs a proper solution for all resource types)
What this PR does / why we need it:
If List Azure Resources Geneva Action is run in a cluster which has VM snapshots in its resource group, the old code will fail due to API Version mismatch. This PR adds a snapshot specific API Version.
Test plan for issue:
I ran a List on snapshots with 2020-05-01 and it didn't fail.
also ((Get-AzureRmResourceProvider -ProviderNamespace Microsoft.Compute).ResourceTypes | Where-Object ResourceTypeName -eq snapshots).ApiVersions shows that the API version is available.
Is there any documentation that needs to be updated for this PR?
N/A - fixes issue with existing code.