Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update path to chunking algorithm in data_ingestion.md #2204

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

cococ0j
Copy link
Contributor

@cococ0j cococ0j commented Nov 30, 2024

Purpose

Update incorrect file path to chunking algorithm in data_ingestion.md

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[x] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[x] No

Type of change

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

Not required as it is a doc change.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff and black manually on my code.

@cococ0j
Copy link
Contributor Author

cococ0j commented Nov 30, 2024

Hi @pamelafox , would you please review this PR? thanks

Copy link
Collaborator

@pamelafox pamelafox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pamelafox pamelafox merged commit 116258c into Azure-Samples:main Dec 1, 2024
5 checks passed
rgrey added a commit to brightsg/ipass-poc that referenced this pull request Dec 2, 2024
Update path to chunking algorithm in data_ingestion.md (Azure-Samples#2204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants