Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding diagnostics #35

Conversation

jmprieur
Copy link
Contributor

Purpose

Add debugging tools to help diagnosing authentication failure and understanding the open id connect pipeline

  • ...

Does this introduce a breaking change?

[ ] Yes
[ x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
  • Test the code
In Startup.cs, uncomment the lines subscribing to the openid connect events.

What to Check

Verify that the following are valid

  • run under debugger
  • observe the traces as the OpenIdConnect message is processed.

@jmprieur jmprieur requested a review from bgavrilMS December 18, 2018 13:23

static async Task OnRedirectToIdentityProvider(RedirectContext context)
{
Debug.WriteLine($"1. Begin {nameof(OnRedirectToIdentityProvider)}");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, @bgavrilMS this would be better.

Copy link
Contributor

@bgavrilMS bgavrilMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmprieur jmprieur merged commit f0b7fea into aspnetcore2-2-signInAndCallGraph Jan 8, 2019
@jmprieur jmprieur deleted the jmprieur/addOpenIdConnectDiagnostics branch January 8, 2019 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants