Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pairing-input aggregation in Honk recursive verifier #934

Closed
ledwards2225 opened this issue Apr 3, 2024 · 2 comments
Closed

Pairing-input aggregation in Honk recursive verifier #934

ledwards2225 opened this issue Apr 3, 2024 · 2 comments
Assignees
@lucasxia01
Milestone
Honk-Noir integra...

Comments

@ledwards2225
Copy link
Collaborator

The Honk recursive verifier is incomplete in the sense that there is no logic for "accumulating" the set of G1 points that constitute the input to a pairing check, i.e. the output of a previous recursive verification. This logic exists for Plonk so we can take inspiration from what's done there, although as usual I suspect there's room for improvement.

Note: One potential wrinkle just occurring to me now is that with Plonk, the G2 points in the pairing are always the same; with Honk, these points depend on the size of the circuit since the degree check will differ. Hopefully there's a simple way to handle this but it needs some thought.
@ledwards2225 ledwards2225 added this to the Honk-Noir integration milestone Apr 3, 2024
@maramihali
Copy link
Contributor

This is an issue relevant for the RollupIVC milestone as well https://github.com/AztecProtocol/barretenberg/milestone/10 but apparently I cannot add two milestones :-? Another thing that occurred to me is that we (might) need to accumulate the pairings from the merge recursive verifiers as well

@lucasxia01 lucasxia01 mentioned this issue May 30, 2024
Merged
lucasxia01 added a commit to AztecProtocol/aztec-packages that referenced this issue Jul 29, 2024
@lucasxia01
feat: add recursive aggregation object to proving/verification keys (#…
f48b069 
…6770)

A step towards addressing (recursive aggregation)
AztecProtocol/barretenberg#1059 and
AztecProtocol/barretenberg#934.

Adds the boolean flag contains_recursive_proof and the vector of indices
recursive_proof_public_input_indices to the proving and (native and
recursive) verification keys. This is setting up aggregation in the
native/recursive verifier that we need for the base rollup and the
solidity verifier.

Also refactors the type of recursive_proof_public_input_indices and
other aggregation objects to be an array instead of a vector.
AztecBot pushed a commit that referenced this issue Jul 30, 2024
@lucasxia01 @AztecBot
feat: add recursive aggregation object to proving/verification keys (…
c09323d 
…#6770)

A step towards addressing (recursive aggregation)
#1059 and
#934.

Adds the boolean flag contains_recursive_proof and the vector of indices
recursive_proof_public_input_indices to the proving and (native and
recursive) verification keys. This is setting up aggregation in the
native/recursive verifier that we need for the base rollup and the
solidity verifier.

Also refactors the type of recursive_proof_public_input_indices and
other aggregation objects to be an array instead of a vector.
@lucasxia01
Copy link
Contributor

Duplicate of #1059.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasxia01 lucasxia01

Labels
None yet
Projects
None yet
Milestone
Honk-Noir integration
Development

No branches or pull requests
3 participants
@maramihali @lucasxia01 @ledwards2225