Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace sorting: Move add gate out of aux block #913

Closed
ledwards2225 opened this issue Mar 18, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#8541
Closed

Trace sorting: Move add gate out of aux block #913

ledwards2225 opened this issue Mar 18, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#8541
Assignees
Milestone

Comments

@ledwards2225
Copy link
Collaborator

Execution trace sorting requires the addition of dummy gates where they were previously not required in cases where one gate was reading into the next row of different gate type. Doing this in all necessary locations causes the double_verify_proof circuit to go beyond the 2^19 limit imposed by WASM + plonk. I'm avoiding one such dummy gate by simply allowing an add gate to be placed into the aux block. (This isn't a long term solution because it requires that both the aux and arithmetic relations run on the entire aux block). Once plonk goes away, this can be removed and replaced with an add gate and a dummy gate, both placed in the arithmetic block.

@ledwards2225 ledwards2225 added this to the Trace Sorting milestone Mar 18, 2024
@lucasxia01 lucasxia01 self-assigned this Sep 13, 2024
lucasxia01 added a commit to AztecProtocol/aztec-packages that referenced this issue Sep 16, 2024
Resolves AztecProtocol/barretenberg#913.

Moves the add gate in aux to the arithmetic block instead. Adds some
tests to check the partitioning of selectors into their blocks.

This used to be blocked by the recursion limit in Plonk (as in this change would've bumped us over the limit), but we don't
care about that anymore (because it's double_verify_proof already goes over 2^19).
AztecBot pushed a commit that referenced this issue Sep 17, 2024
Resolves #913.

Moves the add gate in aux to the arithmetic block instead. Adds some
tests to check the partitioning of selectors into their blocks.

This used to be blocked by the recursion limit in Plonk (as in this change would've bumped us over the limit), but we don't
care about that anymore (because it's double_verify_proof already goes over 2^19).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants