Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSL: Merge aggregation of Honk and AVM RecursionConstraints #1095

Closed
jeanmon opened this issue Sep 5, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#8696
Closed

DSL: Merge aggregation of Honk and AVM RecursionConstraints #1095

jeanmon opened this issue Sep 5, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#8696
Assignees
@lucasxia01
Milestone
Honk-Noir integra...

Comments

@jeanmon
Copy link
Contributor

jeanmon commented Sep 5, 2024

As part of the DSL integration of the avm recursive verifier, the aggregation object pertaining to the AVM recursion constraint is separate from the one handling the Honk recursion constraints.

See acir_format::process_honk_recursion_constraints() and acir_format::process_avm_recursion_constraints() which both initialized an aggregation object.

Ultimately, it would be more efficient for the public kernel/rollup to aggregate them together.
@lucasxia01 lucasxia01 added this to the Honk-Noir integration milestone Sep 5, 2024
@jeanmon jeanmon mentioned this issue Sep 10, 2024
Open
@lucasxia01 lucasxia01 mentioned this issue Sep 23, 2024
Merged
@lucasxia01 lucasxia01 self-assigned this Sep 23, 2024
lucasxia01 added a commit to AztecProtocol/aztec-packages that referenced this issue Sep 24, 2024
@lucasxia01
feat: aggregate honk and avm recursion constraints together (#8696)
3fa9e83 
Closes AztecProtocol/barretenberg#1095.

We should aggregate the aggregation objects generated by the Honk and
AVM recursion constraints. Previously, we were creating 2 separate ones
and adding them to the builder, which would've triggered an assert
failure. This work should allow for circuits (like the public kernel) to
have both Honk and AVM recursion constraints.
AztecBot pushed a commit that referenced this issue Sep 25, 2024
@lucasxia01 @AztecBot
feat: aggregate honk and avm recursion constraints together (#8696)
b7066f2 
Closes #1095.

We should aggregate the aggregation objects generated by the Honk and
AVM recursion constraints. Previously, we were creating 2 separate ones
and adding them to the builder, which would've triggered an assert
failure. This work should allow for circuits (like the public kernel) to
have both Honk and AVM recursion constraints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasxia01 lucasxia01

Labels
None yet
Projects
None yet
Milestone
Honk-Noir integration
Development

Successfully merging a pull request may close this issue.

feat: aggregate honk and avm recursion constraints together AztecProtocol/aztec-packages
2 participants
@lucasxia01 @jeanmon