Skip to content

Commit

Permalink
chore: pin foundry (#5151)
Browse files Browse the repository at this point in the history
I tried increasing gas limit of anvil and disabling it altogether
(--disable-block-gas-limit flag) but it didn't help. In `forge` there is
a `--memory-limit` which is supposed to directly affect this value but
this flag is not exposed on anvil. What is weird that the issue occurs
when running "empty block" test case in
`integration_l1_publisher.test.ts` but it doesn't occur for the bloated
one. This makes me think that it probably really is some kind of bug and
not just a gas limit issue.

What is also weird is that for a [version from 4 days
ago](https://github.com/foundry-rs/foundry/releases/tag/nightly-9ec42d6f03bafbd3b9bb8e258ca67d7887b1f2e7)
I was getting the error as well. I would not expect this given that the
issue started occurring yesterday. I [asked on Foundry support
channel](https://t.me/foundry_support/51173) and hopefully we will get
some feedback.

In the meanwhile I found a version for which all seems to work so I
would merge this PR to not waste too much time on this. We can just
revert it in the future.
  • Loading branch information
benesjan authored and AztecBot committed Mar 13, 2024
1 parent d20d80e commit dbf46ff
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion sol/scripts/install_foundry.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ FOUNDRY_BIN_DIR="$FOUNDRY_DIR/bin"
BIN_URL="https://raw.githubusercontent.com/foundry-rs/foundry/master/foundryup/foundryup"
BIN_PATH="$FOUNDRY_BIN_DIR/foundryup"
FOUNDRY_MAN_DIR="$FOUNDRY_DIR/share/man/man1"
FOUNDRY_VERSION="nightly-de33b6af53005037b463318d2628b5cfcaf39916"

# Clean
rm -rf $FOUNDRY_DIR
Expand All @@ -18,4 +19,4 @@ chmod +x $BIN_PATH
export PATH=$FOUNDRY_BIN_DIR:$PATH

# Use version.
foundryup
foundryup --version $FOUNDRY_VERSION

0 comments on commit dbf46ff

Please sign in to comment.